fix(core): Disable release creation and source maps upload in dev mode #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Jan 27, 2025
| @@ -274,7 +279,7 @@ export function sentryUnpluginFactory({ | |||
| "Release injection disabled via `release.inject` option. Will not inject release." | |||
| ); | |||
| } else if (!options.release.name) { | |||
| logger.warn( | |||
| logger.debug( | |||
There was a problem hiding this comment.
I also took the liberty to relax the log level here. Releases aren't required anymore for debugId-based upload and I've seen build logs this and the log below were added (in fact multiple times due to multi-build-setups of meta frameworks like SvelteKit and Nuxt)
|
Some more context on the Unplugin union-types the |
lforst
reviewed
Jan 27, 2025
| @@ -106,7 +111,7 @@ export function sentryUnpluginFactory({ | |||
|
|
|||
| const options = normalizeUserOptions(userOptions); | |||
|
|
|||
| if (unpluginMetaContext.watchMode || options.disable) { | |||
There was a problem hiding this comment.
I know this is technically not the goal of this PR but thinking about this logic more holistically we probably don't want to disable the entire plugin for dev mode because we have other things that may be valuable in dev mode, like react component annotations or tree shaking utilities (I guess for debugging purposes).
Should we limit this check to just anything that has a side-effect/is invoking Sentry CLI?
There was a problem hiding this comment.
sure, we can adjust this further. I think what we want to disable is release management and sourcemaps upload, right? release and debugId injection should be fine in dev as well, right?
lforst
approved these changes
Jan 28, 2025
Lms24
changed the title
process.env.NODE_ENV
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 31, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.1.0 | 3.1.1 | ## [v3.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#311) - fix(core): Disable release creation and source maps upload in dev mode ([#666](getsentry/sentry-javascript-bundler-plugins#666)) This fix disables any external calls to the Sentry API for managing releases or uploading source maps, when detecting that the plugin is running in dev-mode. While this rarely actually happened, it also polluted the dev server output with unnecessary logs about missing auth tokens, which shouldn't be required in dev mode.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 1, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.1.0 | 3.1.1 | ## [v3.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#311) - fix(core): Disable release creation and source maps upload in dev mode ([#666](getsentry/sentry-javascript-bundler-plugins#666)) This fix disables any external calls to the Sentry API for managing releases or uploading source maps, when detecting that the plugin is running in dev-mode. While this rarely actually happened, it also polluted the dev server output with unnecessary logs about missing auth tokens, which shouldn't be required in dev mode.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 5, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.1.0 | 3.1.2 | ## [v3.1.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#312) - deps: Bump `@sentry/cli` to `2.41.1` ([#671](getsentry/sentry-javascript-bundler-plugins#671)) ## [v3.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#311) - fix(core): Disable release creation and source maps upload in dev mode ([#666](getsentry/sentry-javascript-bundler-plugins#666)) This fix disables any external calls to the Sentry API for managing releases or uploading source maps, when detecting that the plugin is running in dev-mode. While this rarely actually happened, it also polluted the dev server output with unnecessary logs about missing auth tokens, which shouldn't be required in dev mode.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 5, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.1.0 | 3.1.2 | ## [v3.1.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#312) - deps: Bump `@sentry/cli` to `2.41.1` ([#671](getsentry/sentry-javascript-bundler-plugins#671)) ## [v3.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#311) - fix(core): Disable release creation and source maps upload in dev mode ([#666](getsentry/sentry-javascript-bundler-plugins#666)) This fix disables any external calls to the Sentry API for managing releases or uploading source maps, when detecting that the plugin is running in dev-mode. While this rarely actually happened, it also polluted the dev server output with unnecessary logs about missing auth tokens, which shouldn't be required in dev mode.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 7, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.1.0 | 3.1.2 | ## [v3.1.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#312) - deps: Bump `@sentry/cli` to `2.41.1` ([#671](getsentry/sentry-javascript-bundler-plugins#671)) ## [v3.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#311) - fix(core): Disable release creation and source maps upload in dev mode ([#666](getsentry/sentry-javascript-bundler-plugins#666)) This fix disables any external calls to the Sentry API for managing releases or uploading source maps, when detecting that the plugin is running in dev-mode. While this rarely actually happened, it also polluted the dev server output with unnecessary logs about missing auth tokens, which shouldn't be required in dev mode.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 8, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.1.0 | 3.1.2 | ## [v3.1.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#312) - deps: Bump `@sentry/cli` to `2.41.1` ([#671](getsentry/sentry-javascript-bundler-plugins#671)) ## [v3.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#311) - fix(core): Disable release creation and source maps upload in dev mode ([#666](getsentry/sentry-javascript-bundler-plugins#666)) This fix disables any external calls to the Sentry API for managing releases or uploading source maps, when detecting that the plugin is running in dev-mode. While this rarely actually happened, it also polluted the dev server output with unnecessary logs about missing auth tokens, which shouldn't be required in dev mode.
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perfect PR id 😈
This PR
watchmodeflag in theory but not in practise, we'd always return the actual plugins.writeBundlehook usually not being called in dev. But, most importantly alsocloses #344
probably also closes #520 (I'll leave a reply to get confirmation)